Delete PackageServiceInstance on kody-runtime by kentcdodds · Pull Request #1560 · kody-hq/kody

kentcdodds · 2026-08-19T11:02:28Z

Intent

Finish the Durable Object cleanup after #1559. Production kody-runtime no longer has the transferred PackageServiceInstance binding, so tag v2 deleted_classes can apply.

Summary

Restore runtime-worker tag v2 deleted_classes (top-level and preview).
Remove the temporary stub export from Export PackageServiceInstance stub so runtime can drop its binding #1559.
Keep the existing tools/ci/do-deletion-allowlist.json entry.

Depends on successful production deploy of #1559: https://github.com/kentcdodds/kody/actions/runs/32245113886

Testing

npm run deploy-guardrails:check — pass
format / docs temporal / lint — pass
Preview success criterion: runtime worker first deploy applies v1 then v2 without 10070/10074
Production success criterion: runtime worker deploy applies v2 without 10061/10064

System changes

Destructive Durable Object class deletion. No user-facing API.

System recap — extends existing primitives (medium risk)

Mode: recap · Base: main @ 7928ec6f · Head: 2194f6c1

Classification: extends — this PR deletes the retired runtime Durable Object class after the binding-only deploy.

Primitives touched

Primitive	Group	Impact
`package-runtime`	runtime	extends — delete `PackageServiceInstance` and remove the stub export

Change flow

#1559 left the class exported as a stub with no binding. This PR deletes the class.

sequenceDiagram
	actor Operator
	participant runtimeWorker as kody-runtime
	participant cloudflare as Cloudflare DO registry
	Operator->>runtimeWorker: merge this PR
	runtimeWorker->>cloudflare: apply v2 deleted_classes
	runtimeWorker->>cloudflare: stop exporting PackageServiceInstance
	Note over cloudflare: binding already gone after #1559
	cloudflare-->>runtimeWorker: class deleted

Before / after

	#1559 production	This PR
Binding	absent	absent
Class export	stub	removed
Tag `v2`	omitted	`deleted_classes`

Invariants

Protected v1 transfer / preview new_sqlite_classes stay unchanged. Do not edit tools/ci/durable-object-baseline.json.

Summary by CodeRabbit

Bug Fixes
- Completed cleanup of the retired package service during deployments.
- Improved production and preview migration handling to safely remove obsolete runtime state.
- Clarified deployment errors and migration requirements for preview environments.
Documentation
- Updated architecture and deployment guidance to reflect the revised package service deletion workflow.

… gone. Restore runtime-worker tag v2 deleted_classes and remove the temporary stub export. Production already dropped the transferred binding in #1559, so this deploy can delete the class without Cloudflare 10061 or 10064. Co-authored-by: me <me@kentcdodds.com>

coderabbitai · 2026-08-19T11:02:48Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 67f4dc6d-247a-49c6-8bea-6cb3822183c5

📥 Commits

Reviewing files that changed from the base of the PR and between 7928ec6 and 2194f6c.

📒 Files selected for processing (5)

docs/contributing/architecture/runtime-worker-migration-runbook.md
docs/contributing/decisions/0025-no-package-services-primitive.md
packages/runtime-worker/wrangler.jsonc
packages/worker/src/package-service-instance-stub.ts
packages/worker/src/runtime-worker.ts

💤 Files with no reviewable changes (2)

packages/worker/src/package-service-instance-stub.ts
packages/worker/src/runtime-worker.ts

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The PR completes PackageServiceInstance removal. It adds production and preview v2 deletion migrations, removes the temporary stub and runtime export, and updates migration documentation.

Changes

PackageServiceInstance removal

Layer / File(s)	Summary
Migration deletion and runtime cleanup `packages/runtime-worker/wrangler.jsonc`, `packages/worker/src/package-service-instance-stub.ts`, `packages/worker/src/runtime-worker.ts`	Production and preview add `v2` migrations that delete `PackageServiceInstance`. The temporary stub and runtime export are removed.
Deployment guidance `docs/contributing/architecture/runtime-worker-migration-runbook.md`, `docs/contributing/decisions/0025-no-package-services-primitive.md`	The documentation describes the production and preview migration sequence, the deletion allowlist, and preview error 10074 conditions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to 2194f

The PR removes a retired Durable Object export and enables its deletion; the remaining bounded risk is inconsistent preview guidance about deployment order, which could cause migration confusion or failure. It is mergeable with explicit owner verification of the preview sequence.

Possibly related PRs

kentcdodds/kody#1384: Transfers PackageServiceInstance to the runtime worker.
kentcdodds/kody#1559: Defers cleanup completed by these deletion migrations and export removals.
kentcdodds/kody#1558: Defers PackageServiceInstance deletion completed by this PR.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely identifies the primary change: deleting PackageServiceInstance from kody-runtime.
Description check	✅ Passed	The description includes Intent, Summary, Testing, and System changes sections with relevant migration details, dependencies, risks, and success criteria.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch cursor/runtime-do-delete-class-8713

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-08-19T11:05:43Z

🔎 Preview deployed: https://kody-pr-1560.kody-a99.workers.dev

Worker: kody-pr-1560
Runtime worker: kody-pr-1560-runtime (https://kody-pr-1560-runtime.kody-a99.workers.dev)
D1: kody-pr-1560-db
KV: kody-pr-1560-oauth-kv

Mocks:

cloudflare: https://kody-pr-1560-mock-cloudflare.kody-a99.workers.dev/__mocks (kody-pr-1560-mock-cloudflare)

kody-bot marked this pull request as ready for review August 19, 2026 11:03

kody-bot merged commit 09f8faa into main Aug 19, 2026
19 checks passed

kody-bot deleted the cursor/runtime-do-delete-class-8713 branch August 19, 2026 11:08

kody-bot mentioned this pull request Aug 19, 2026

Confirm leftover kind='service' storage inventory is purged, then remove the retired-service purge lane #1565

Closed

kentcdodds mentioned this pull request Aug 19, 2026

docs: record completed PackageServiceInstance delete sequence #1566

Closed

github-actions Bot mentioned this pull request Aug 20, 2026

Upstream updates available (kentcdodds/kody) kornelov1cs/kody#1

Open

Navigation Menu

Repository navigation

Delete PackageServiceInstance on kody-runtime - #1560

Delete PackageServiceInstance on kody-runtime#1560
kody-bot merged 1 commit into
mainfrom
cursor/runtime-do-delete-class-8713

kentcdodds commented Aug 19, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 19, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kentcdodds commented Aug 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Intent

Summary

Testing

System changes

Primitives touched

Change flow

Before / after

Invariants

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kentcdodds commented Aug 19, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 19, 2026 •

edited

Loading